Skip to content

VSB-TUO/Commented out not wanted ORCID requests #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milanmajchrak merged 1 commit into from
Oct 22, 2025
Merged

VSB-TUO/Commented out not wanted ORCID requests #1128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions dspace-api/src/main/java/org/dspace/external/CachingOrcidRestConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,17 @@ public ExpandedSearchConverter.Results search(String query, int start, int limit
*/
@Cacheable(cacheNames = "orcid-labels", unless = "#result == null")
public String getLabel(String orcid) {
log.debug("getLabel: " + orcid);
// in theory, we could use orcid.org/v3.0/<ORCID>/personal-details, but didn't want to write another converter
ExpandedSearchConverter.Results search = search("orcid:" + orcid, 0, 1);
if (search.isOk() && search.numFound() > 0) {
return search.results().get(0).label();
}
log.debug("getLabel: " + orcid + " - ORCID lookup disabled, returning null");
// COMMENTED OUT: ORCID API calls disabled to reduce excessive requests
// Return null to force indexing to use the metadata value instead
return null;
// ORIGINAL CODE (commented out):
// in theory, we could use orcid.org/v3.0/<ORCID>/personal-details, but didn't want to write another converter
// ExpandedSearchConverter.Results search = search("orcid:" + orcid, 0, 1);
// if (search.isOk() && search.numFound() > 0) {
// return search.results().get(0).label();
// }
// return null;
}

protected String getAccessToken(String clientSecret, String clientId, String OAUTHUrl) {
Expand Down
Loading