Merged
Conversation
Collaborator
Paurikova2
commented
Oct 15, 2025
| Phases | MP | MM | MB | MR | JM | Total |
|---|---|---|---|---|---|---|
| ETA | 0 | 0 | 0 | 0 | 0 | 0 |
| Developing | 0 | 0 | 0 | 0 | 0 | 0 |
| Review | 0 | 0 | 0 | 0 | 0 | 0 |
| Total | - | - | - | - | - | 0 |
| ETA est. | 0 | |||||
| ETA cust. | - | - | - | - | - | 0 |
There was a problem hiding this comment.
Pull Request Overview
This PR updates a Windows batch script to properly remove Solr configsets before copying new ones. The change fixes command syntax by replacing Unix-style rm -rf commands with Windows-compatible rd /s /q commands and adds a descriptive comment.
- Replaced Unix
rm -rfcommand with Windowsrd /s /qcommands - Added explicit removal of each configset directory separately
- Added a comment explaining the copy operation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
milanmajchrak
approved these changes
Oct 15, 2025
Collaborator
|
@Paurikova2 This should be also propagated into dtq-dev, right? |
Collaborator
Author
|
@milanmajchrak yes |
Collaborator
Author
|
@milanmajchrak |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.