VSB-TUO/Load url from config#1110
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors VSB URL configuration management by moving hardcoded URLs to a centralized configuration file and creating a shared utility module for loading these values.
- Introduces a new
vsb_config.pymodule for loading VSB URLs from the DSpace configuration file - Replaces hardcoded URLs with configuration-based loading in existing scripts
- Updates the main DSpace configuration to include VSB base and test URLs
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| dspace/config/vsb/vsb_config.py | New utility module for loading VSB URLs from configuration with error handling |
| dspace/config/vsb/update_forms.py | Updated to import URLs from the new config module |
| dspace/config/vsb/generate-forms.py | Updated to import URLs from the new config module |
| dspace/config/vsb/fetch-vocabularies.py | Removed hardcoded URLs and imports from config module, includes cleanup |
| dspace/config/dspace.cfg | Added VSB URL configuration entries |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@milanmajchrak the changes in file as (new line, etc.) are because of the precommit. |
|
Waiting for the python scrips review |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Problem description
Load vsb.base.url and vsb.test.url from config.