Skip to content

VSB-TUO/Load url from config#1110

Merged
milanmajchrak merged 17 commits intocustomer/vsb-tuofrom
vsb-tuo/load-url-from-config
Jan 12, 2026
Merged

VSB-TUO/Load url from config#1110
milanmajchrak merged 17 commits intocustomer/vsb-tuofrom
vsb-tuo/load-url-from-config

Conversation

@Paurikova2
Copy link
Collaborator

Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 1 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

Load vsb.base.url and vsb.test.url from config.

@Paurikova2 Paurikova2 requested a review from Copilot October 7, 2025 09:02
@Paurikova2 Paurikova2 linked an issue Oct 7, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors VSB URL configuration management by moving hardcoded URLs to a centralized configuration file and creating a shared utility module for loading these values.

  • Introduces a new vsb_config.py module for loading VSB URLs from the DSpace configuration file
  • Replaces hardcoded URLs with configuration-based loading in existing scripts
  • Updates the main DSpace configuration to include VSB base and test URLs

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
dspace/config/vsb/vsb_config.py New utility module for loading VSB URLs from configuration with error handling
dspace/config/vsb/update_forms.py Updated to import URLs from the new config module
dspace/config/vsb/generate-forms.py Updated to import URLs from the new config module
dspace/config/vsb/fetch-vocabularies.py Removed hardcoded URLs and imports from config module, includes cleanup
dspace/config/dspace.cfg Added VSB URL configuration entries

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Paurikova2 Paurikova2 requested a review from Copilot October 7, 2025 10:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Paurikova2 Paurikova2 requested a review from Copilot October 7, 2025 10:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Paurikova2
Copy link
Collaborator Author

@milanmajchrak the changes in file as (new line, etc.) are because of the precommit.

@milanmajchrak
Copy link
Collaborator

Waiting for the python scrips review

@Paurikova2 Paurikova2 requested a review from Copilot October 14, 2025 12:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Paurikova2 Paurikova2 requested a review from Copilot October 14, 2025 13:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@milanmajchrak milanmajchrak merged commit f9c119c into customer/vsb-tuo Jan 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VSB-TUO/evyuka URL je public - dat to do env

4 participants