Skip to content

VSB-TUO/Fix ConfigFileRestControllerIT#1100

Merged
milanmajchrak merged 1 commit intocustomer/vsb-tuofrom
vsb-tuo/fix-config-file-rest-controller-test
Sep 25, 2025
Merged

VSB-TUO/Fix ConfigFileRestControllerIT#1100
milanmajchrak merged 1 commit intocustomer/vsb-tuofrom
vsb-tuo/fix-config-file-rest-controller-test

Conversation

@Paurikova2
Copy link
Collaborator

Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

Error when mvn install -Dit.test=org.dspace.app.rest.ConfigFileRestControllerIT,org.dspace.app.rest.eperson.DeleteEPersonSubmitterIT -DskipIntegrationTests=false -DfailIfNoTests=false -Dcheckstyle.skip.

@Paurikova2 Paurikova2 requested a review from Copilot September 25, 2025 09:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the ConfigFileRestControllerIT integration test by switching from using the main dspace.cfg file to a dedicated test configuration file. The change prevents test execution failures that occur when trying to modify the main configuration file during testing.

Key changes:

  • Added test-dspace.cfg to the list of updateable configuration files in the test setup
  • Updated test methods to use test-dspace.cfg instead of dspace.cfg for file modification operations
  • Created a new test configuration file test-dspace.cfg in the test data directory

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ConfigFileRestControllerIT.java Updates test setup and test methods to use dedicated test config file instead of main dspace.cfg
test-dspace.cfg Creates new test configuration file with minimal content for testing purposes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@milanmajchrak milanmajchrak merged commit 8a71c1e into customer/vsb-tuo Sep 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants