VSB-TUO/Fix ConfigFileRestControllerIT#1100
Merged
milanmajchrak merged 1 commit intocustomer/vsb-tuofrom Sep 25, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the ConfigFileRestControllerIT integration test by switching from using the main dspace.cfg file to a dedicated test configuration file. The change prevents test execution failures that occur when trying to modify the main configuration file during testing.
Key changes:
- Added
test-dspace.cfgto the list of updateable configuration files in the test setup - Updated test methods to use
test-dspace.cfginstead ofdspace.cfgfor file modification operations - Created a new test configuration file
test-dspace.cfgin the test data directory
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ConfigFileRestControllerIT.java | Updates test setup and test methods to use dedicated test config file instead of main dspace.cfg |
| test-dspace.cfg | Creates new test configuration file with minimal content for testing purposes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Error when mvn install -Dit.test=org.dspace.app.rest.ConfigFileRestControllerIT,org.dspace.app.rest.eperson.DeleteEPersonSubmitterIT -DskipIntegrationTests=false -DfailIfNoTests=false -Dcheckstyle.skip.