Skip to content

VSB-TUO/Oai-phm nusl does not work#1045

Merged
milanmajchrak merged 8 commits intocustomer/vsb-tuofrom
vsb-tuo/oai-phm-nusl-does-not-work
Sep 5, 2025
Merged

VSB-TUO/Oai-phm nusl does not work#1045
milanmajchrak merged 8 commits intocustomer/vsb-tuofrom
vsb-tuo/oai-phm-nusl-does-not-work

Conversation

@Paurikova2
Copy link
Collaborator

@Paurikova2 Paurikova2 commented Aug 21, 2025

Phases MP MM MB MR JM Total
ETA 1 0 0 0 0 0
Developing 4 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

image ## Problem solution Fix EXSLT date formatting function compatibility issue in mets_nusl.xsl by replacing format-dateTime() with XSLT 2.0 standard date formatting to resolve Saxon processor errors.

@coderabbitai
Copy link

coderabbitai bot commented Aug 21, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vsb-tuo/oai-phm-nusl-does-not-work

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Paurikova2 Paurikova2 requested a review from Copilot August 21, 2025 09:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a compatibility issue with EXSLT date formatting functions in the METS NUSL crosswalk configuration by upgrading to XSLT 2.0 and replacing deprecated EXSLT date functions with standard XSLT 2.0 date formatting.

  • Upgrades XSLT version from 1.0 to 2.0
  • Replaces EXSLT date:format-date() functions with XSLT 2.0 format-dateTime() function
  • Resolves Saxon processor errors related to date formatting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@milanmajchrak milanmajchrak merged commit ef8650f into customer/vsb-tuo Sep 5, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants