Skip to content

Remove XESmartTarget Commands and Fix DAC #9783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/dbatools-library-version.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"version": "2025.8.5",
"version": "2025.8.17-preview-dac-20250817060550",
"notes": "Version of dbatools.library to use for CI/CD and development"
}
1 change: 1 addition & 0 deletions .github/workflows/gallery.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
paths-ignore:
- '**/*.md'
- '**/*.json'
- '!.github/dbatools-library-version.json'
- 'docs/**'
- '.github/FUNDING.yml'
- '.github/ISSUE_TEMPLATE/**'
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/integration-tests-repl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
paths-ignore:
- '**/*.md'
- '**/*.json'
- '!.github/dbatools-library-version.json'
- 'docs/**'
- '.github/FUNDING.yml'
- '.github/ISSUE_TEMPLATE/**'
Expand Down
50 changes: 15 additions & 35 deletions .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
paths-ignore:
- '**/*.md'
- '**/*.json'
- '!.github/dbatools-library-version.json'
- 'docs/**'
- '.github/FUNDING.yml'
- '.github/ISSUE_TEMPLATE/**'
Expand Down Expand Up @@ -56,20 +57,15 @@ jobs:
Write-Output "Preview version detected, bypassing PSModuleCache and using install script"
./.github/scripts/install-dbatools-library.ps1

- name: Check file health and set encryption values
- name: Set encryption values
run: |
Import-Module ./dbatools.psd1 -Force
Get-Module dbatools.library | Select-Object -ExpandProperty Path -OutVariable lib | Write-Warning
$lib = Split-Path -Path $lib -Parent
Get-ChildItem (Join-Path $lib -ChildPath core/lib/dac/linux) | Write-Warning
Set-DbatoolsConfig -FullName sql.connection.trustcert -Value $true -Register
Set-DbatoolsConfig -FullName sql.connection.encrypt -Value $false -Register
Get-DbatoolsConfigValue -FullName sql.connection.encrypt | Write-Warning
mkdir /tmp/DbatoolsExport

- name: Ensure sqlpackage is executable
run: chmod +x /home/runner/.local/share/powershell/Modules/dbatools.library/core/lib/dac/linux/sqlpackage || true

- name: Setup docker images
run: |
# create a shared network
Expand All @@ -84,15 +80,11 @@ jobs:
run: |
gh repo clone dataplat/appveyor-lab

- name: Install SqlPackage for DAC tests
run: |
Import-Module ./dbatools.psd1 -Force
Install-DbaSqlPackage -Verbose

- name: Install XESmartTarget for Extended Events tests
- name: Install SqlPackage
shell: pwsh
run: |
Import-Module ./dbatools.psd1 -Force
Install-DbaXESmartTarget -Force
Install-DbaSqlPackage -Force -Verbose

- name: Run tests
env:
Expand Down Expand Up @@ -172,17 +164,11 @@ jobs:
$PSDefaultParameterValues["*:SqlCredential"] = $cred
Connect-DbaInstance

- name: Install SqlPackage for DAC tests (PowerShell)
shell: powershell
run: |
Import-Module ./dbatools -Force
Install-DbaSqlPackage -Verbose

- name: Install XESmartTarget for Extended Events tests (PowerShell)
shell: powershell
- name: Install SqlPackage
shell: pwsh
run: |
Import-Module ./dbatools -Force
Install-DbaXESmartTarget -Force
Import-Module ./dbatools.psd1 -Force
Install-DbaSqlPackage -Force -Verbose

- name: Run PowerShell tests
env:
Expand All @@ -192,18 +178,6 @@ jobs:
shell: powershell
run: $null = Invoke-Pester .github/scripts/gh-winactions.ps1 -Output Detailed -PassThru

- name: Install SqlPackage for DAC tests (pwsh)
shell: pwsh
run: |
Import-Module ./dbatools -Force
Install-DbaSqlPackage -Verbose

- name: Install XESmartTarget for Extended Events tests (pwsh)
shell: pwsh
run: |
Import-Module ./dbatools -Force
Install-DbaXESmartTarget -Force

- name: Run pwsh tests
env:
TENANTID: ${{secrets.TENANTID}}
Expand Down Expand Up @@ -254,6 +228,12 @@ jobs:
run: |
gh repo clone dataplat/appveyor-lab

- name: Install SqlPackage
shell: pwsh
run: |
Import-Module ./dbatools.psd1 -Force
Install-DbaSqlPackage -Force -Verbose

- name: Run macOS tests
env:
TENANTID: ${{secrets.TENANTID}}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/xplat-import.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ on:
paths-ignore:
- '**/*.md'
- '**/*.json'
- '!.github/dbatools-library-version.json'
- 'docs/**'
- '.github/FUNDING.yml'
- '.github/ISSUE_TEMPLATE/**'
Expand Down
1 change: 1 addition & 0 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ skip_commits:
files:
- '**/*.md'
- '**/*.json'
- '!.github/dbatools-library-version.json'
- 'docs/**'
- '.github/FUNDING.yml'
- '.github/ISSUE_TEMPLATE/**'
Expand Down
11 changes: 0 additions & 11 deletions dbatools.psd1
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@
'Export-DbaSysDbUserObject',
'Export-DbatoolsConfig',
'Export-DbaUser',
'Export-DbaXECsv',
'Export-DbaXESession',
'Export-DbaXESessionTemplate',
'Find-DbaAgentJob',
Expand Down Expand Up @@ -409,7 +408,6 @@
'Get-DbaXESessionTarget',
'Get-DbaXESessionTargetFile',
'Get-DbaXESessionTemplate',
'Get-DbaXESmartTarget',
'Get-DbaXEStore',
'Grant-DbaAgPermission',
'Import-DbaCsv',
Expand All @@ -426,7 +424,6 @@
'Install-DbaSqlPackage',
'Install-DbaSqlWatch',
'Install-DbaWhoIsActive',
'Install-DbaXESmartTarget',
'Invoke-DbaDbAzSqlTip',
'Invoke-DbaAdvancedInstall',
'Invoke-DbaAdvancedRestore',
Expand Down Expand Up @@ -517,11 +514,6 @@
'New-DbaSqlParameter',
'New-DbatoolsSupportPackage',
'New-DbaXESession',
'New-DbaXESmartCsvWriter',
'New-DbaXESmartEmail',
'New-DbaXESmartQueryExec',
'New-DbaXESmartReplay',
'New-DbaXESmartTableWriter',
'Publish-DbaDacPackage',
'Read-DbaAuditFile',
'Read-DbaBackupHeader',
Expand Down Expand Up @@ -580,7 +572,6 @@
'Remove-DbaSpn',
'Remove-DbaTrace',
'Remove-DbaXESession',
'Remove-DbaXESmartTarget',
'Rename-DbaDatabase',
'Rename-DbaLogin',
'Repair-DbaDbMirror',
Expand Down Expand Up @@ -651,7 +642,6 @@
'Start-DbaService',
'Start-DbaTrace',
'Start-DbaXESession',
'Start-DbaXESmartTarget',
'Stop-DbaAgentJob',
'Stop-DbaEndpoint',
'Stop-DbaExternalProcess',
Expand All @@ -660,7 +650,6 @@
'Stop-DbaService',
'Stop-DbaTrace',
'Stop-DbaXESession',
'Stop-DbaXESmartTarget',
'Suspend-DbaAgDbDataMovement',
'Sync-DbaAvailabilityGroup',
'Sync-DbaLoginPermission',
Expand Down
13 changes: 0 additions & 13 deletions dbatools.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -566,8 +566,6 @@ if ($PSVersionTable.PSVersion.Major -lt 5) {
'New-DbaAgentProxy',
'Test-DbaDbLogShipStatus',
'Get-DbaXESessionTarget',
'New-DbaXESmartTargetResponse',
'New-DbaXESmartTarget',
'Get-DbaDbVirtualLogFile',
'Get-DbaBackupInformation',
'Start-DbaXESession',
Expand Down Expand Up @@ -597,11 +595,6 @@ if ($PSVersionTable.PSVersion.Major -lt 5) {
'Remove-DbaXESession',
'New-DbaXESession',
'Get-DbaXEStore',
'New-DbaXESmartTableWriter',
'New-DbaXESmartReplay',
'New-DbaXESmartEmail',
'New-DbaXESmartQueryExec',
'Start-DbaXESmartTarget',
'Get-DbaDbOrphanUser',
'Get-DbaOpenTransaction',
'Get-DbaDbLogShipError',
Expand All @@ -616,13 +609,9 @@ if ($PSVersionTable.PSVersion.Major -lt 5) {
'Get-DbaXEObject',
'ConvertTo-DbaDataTable',
'Find-DbaDbDisabledIndex',
'Get-DbaXESmartTarget',
'Remove-DbaXESmartTarget',
'Stop-DbaXESmartTarget',
'Get-DbaRegServerGroup',
'New-DbaDbUser',
'Measure-DbaDiskSpaceRequirement',
'New-DbaXESmartCsvWriter',
'Invoke-DbaXeReplay',
'Find-DbaInstance',
'Test-DbaDiskSpeed',
Expand Down Expand Up @@ -810,7 +799,6 @@ if ($PSVersionTable.PSVersion.Major -lt 5) {
'Install-DbaFirstResponderKit',
'Install-DbaSqlPackage',
'Install-DbaWhoIsActive',
'Install-DbaXESmartTarget',
'Update-Dbatools',
'Add-DbaServerRoleMember',
'Get-DbatoolsPath',
Expand Down Expand Up @@ -941,7 +929,6 @@ if ($PSVersionTable.PSVersion.Major -lt 5) {
'Add-DbaPfDataCollectorCounter',
'Remove-DbaPfDataCollectorCounter',
'Get-DbaPfAvailableCounter',
'Export-DbaXECsv',
'Get-DbaOperatingSystem',
'Get-DbaComputerSystem',
'Set-DbaPrivilege',
Expand Down
86 changes: 0 additions & 86 deletions private/functions/Get-XESmartTargetPath.ps1

This file was deleted.

Loading
Loading