Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pester migration - Second batch #9530

Merged
merged 29 commits into from
Oct 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
8b93039
revert to re-fix
potatoqualitee Oct 25, 2024
c4bcd7b
update instructions to be a little shorter
potatoqualitee Oct 25, 2024
43ce0a5
follow slightly new format
potatoqualitee Oct 25, 2024
7c61359
uncomment skipper
potatoqualitee Oct 25, 2024
69b7dc3
Update tests
potatoqualitee Oct 25, 2024
fca2562
fix param checker - we will be checking for whatif and confirm
potatoqualitee Oct 25, 2024
b5be793
shorten var, fix test
potatoqualitee Oct 25, 2024
a09937f
lez see
potatoqualitee Oct 25, 2024
664904e
move param test
potatoqualitee Oct 25, 2024
a6958ca
fix failures
potatoqualitee Oct 25, 2024
eaabf51
one change
potatoqualitee Oct 25, 2024
ebe6660
ReorgParams
potatoqualitee Oct 25, 2024
8e085ac
i dunno
potatoqualitee Oct 25, 2024
a92e29f
maybe
potatoqualitee Oct 25, 2024
9ac5114
trying to get it to work locally
potatoqualitee Oct 26, 2024
e48f744
who knows, im about to skip it
potatoqualitee Oct 26, 2024
3c085e6
add defaults
potatoqualitee Oct 26, 2024
4e85fba
move things
potatoqualitee Oct 26, 2024
b3f5560
add defaults
potatoqualitee Oct 26, 2024
03d1cc6
move it back to top, expected is needed for the foreach
potatoqualitee Oct 26, 2024
2e02db1
aider cleanup
potatoqualitee Oct 26, 2024
244e129
fix test
potatoqualitee Oct 26, 2024
720dc05
it should just be skipped, it shouldnt try to bring over the notifica…
potatoqualitee Oct 26, 2024
f23f7c6
that test got all kinds of messed up
potatoqualitee Oct 26, 2024
2339c66
oops, forgot to actually run the code (do Add-DbaPfDataCollectorCounter)
potatoqualitee Oct 26, 2024
e26b8b7
fix scope
potatoqualitee Oct 26, 2024
881bfc2
fix scope
potatoqualitee Oct 26, 2024
ffddf03
fix prompt
potatoqualitee Oct 26, 2024
addd41f
turns out the scoping was right all along
potatoqualitee Oct 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix param checker - we will be checking for whatif and confirm
  • Loading branch information
potatoqualitee committed Oct 25, 2024
commit fca2562cc09b328447a08db199cf072b484bf3c4
3 changes: 1 addition & 2 deletions .aider/prompts/conventions.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,7 @@ Describe "Get-DbaDatabase" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions .aider/prompts/template.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

You are an AI assistant created by Anthropic to help migrate Pester tests for the **dbatools PowerShell module** from version 4 to version 5. Analyze and update the file `/workspace/tests/--CMDNAME--.Tests.ps1` according to the instructions in conventions.md.

Required parameters for this command:
--PARMZ--

Command name:
--CMDNAME--

Parameters for this command:
--PARMZ--

Before responding, verify that your answer adheres to the specified coding and migration guidelines.
3 changes: 1 addition & 2 deletions tests/Add-DbaAgDatabase.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ Describe "Add-DbaAgDatabase" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Add-DbaAgListener.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,7 @@ Describe "Add-DbaAgListener" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Add-DbaAgReplica.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ Describe "Add-DbaAgReplica" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Add-DbaComputerCertificate.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ Describe "Add-DbaComputerCertificate" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Add-DbaDbMirrorMonitor.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ Describe "Add-DbaDbMirrorMonitor" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Add-DbaDbRoleMember.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ Describe "Add-DbaDbRoleMember" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Add-DbaExtendedProperty.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ Describe "Add-DbaExtendedProperty" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Add-DbaPfDataCollectorCounter.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ Describe "Add-DbaPfDataCollectorCounter" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Add-DbaRegServer.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ Describe "Add-DbaRegServer" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Add-DbaRegServerGroup.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ Describe "Add-DbaRegServerGroup" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Add-DbaReplArticle.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ Describe "Add-DbaReplArticle" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Add-DbaServerRoleMember.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ Describe "Add-DbaServerRoleMember" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Backup-DbaComputerCertificate.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ Describe "Backup-DbaComputerCertificate" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Backup-DbaDbCertificate.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ Describe "Backup-DbaDbCertificate" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Backup-DbaDbMasterKey.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ Describe "Backup-DbaDbMasterKey" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Backup-DbaServiceMasterKey.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ Describe "Backup-DbaServiceMasterKey" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Clear-DbaConnectionPool.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ Describe "Clear-DbaConnectionPool" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Clear-DbaLatchStatistics.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ Describe "Clear-DbaLatchStatistics" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Clear-DbaPlanCache.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ Describe "Clear-DbaPlanCache" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Clear-DbaWaitStatistics.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ Describe "Clear-DbaWaitStatistics" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Convert-DbaLsn.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ Describe "Convert-DbaLSN" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}

Expand Down
3 changes: 1 addition & 2 deletions tests/Convert-DbaMaskingValue.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ Describe "Convert-DbaMaskingValue" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/ConvertTo-DbaTimeline.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ Describe "ConvertTo-DbaTimeline" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/ConvertTo-DbaXESession.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ Describe "ConvertTo-DbaXESession" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Copy-DbaAgentAlert.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ Describe "Copy-DbaAgentAlert" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
3 changes: 1 addition & 2 deletions tests/Copy-DbaAgentJob.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ Describe "Copy-DbaAgentJob" -Tag "IntegrationTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}

Expand Down
3 changes: 1 addition & 2 deletions tests/Copy-DbaAgentJobCategory.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ Describe "Copy-DbaAgentJobCategory" -Tag "IntegrationTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}

Expand Down
3 changes: 1 addition & 2 deletions tests/Copy-DbaAgentOperator.Tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ Describe "Copy-DbaAgentOperator" -Tag "UnitTests" {
}

It "Should have exactly the number of expected parameters" {
$actualParameters = $command.Parameters.Keys | Where-Object { $PSItem -notin "WhatIf", "Confirm" }
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $actualParameters | Should -BeNullOrEmpty
Compare-Object -ReferenceObject $expectedParameters -DifferenceObject $command.Parameters.Keys | Should -BeNullOrEmpty
}
}
}
Expand Down
Loading