Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export credential #8794

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Conversation

ACALVETT
Copy link
Contributor

@ACALVETT ACALVETT commented Mar 6, 2023

Please read -- recent changes to our repo

On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.

PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.

  • Please confirm you have the smaller repo (85MB .git directory vs 275MB or 110MB or 185MB .git directory)

Type of Change

  • Bug fix (non-breaking change, fixes , fixes Export-DbaCredential does not include cryptographic provider #8793
  • New feature (non-breaking change, adds functionality
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Add the missing syntax to the export credential when a provider is used.

Commands to test

Export-DbaCredential
Get-DecrypedtObject

@ACALVETT
Copy link
Contributor Author

ACALVETT commented Mar 6, 2023

I did not add new pester tests as i was not sure how to add the required provider to the build to enable me to create a credential referencing the provider. Happy to add tests if someone can add to the build the SQL Server Connector https://www.microsoft.com/en-us/download/details.aspx?id=45344

@potatoqualitee
Copy link
Member

aweosme, thank you!

@potatoqualitee potatoqualitee merged commit 4f0ece7 into dataplat:development Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export-DbaCredential does not include cryptographic provider
2 participants