Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-DbaDbSchema: returning standard properties on the return object #8775

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

lancasteradam
Copy link
Contributor

Please read -- recent changes to our repo

On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.

PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.

  • Please confirm you have the smaller repo (85MB .git directory vs 275MB or 110MB or 185MB .git directory)

Type of Change

  • Bug fix (non-breaking change, fixes Get-DbaDbSchema does not output module's standard properties #8742 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Minor change to update the return object to have the standard properties.

@wsmelton
Copy link
Member

Something seems to have changed in GitHub workflows because I've started seeing many of our PRs where these are showing "waiting for status to be reported" as if they have not run.
image

@potatoqualitee
Copy link
Member

Agreed @wsmelton -- it's only for remote branches. Will research when I get a moment 👎🏼

@potatoqualitee
Copy link
Member

Thank you, Adam! this will be incldued in 2.0 prerelease 2

@potatoqualitee potatoqualitee merged commit 4f93f17 into dataplat:development Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get-DbaDbSchema does not output module's standard properties
3 participants