Get-DbaAgBackupHistory - Remove extra param #8613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a bug, didn't remove the new parameter from the subsequent call to the underlying backup cmdlet
|
Before we merge: Maybe add the parameter to Get-DbaDbBackupHistory? That might solve #5399. |
|
I'd love that! |
|
We can do that in a new PR, Andreas, I'll merge this one and the other is listed as fix in 2.0, so we'll get to that one before publishing |
potatoqualitee
changed the title
|
Thanks again @TakeshiKovacs ! |
potatoqualitee
pushed a commit
that referenced
this pull request
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug, didn't remove the new parameter from the subsequent call to the underlying backup cmdlet
Please read -- recent changes to our repo
On October 2, 2022, we removed some bloat from our repository. This change requires that all contributors reclone or reset their repo using the following code:
You can also just delete your dbatools directory and have GitHub Desktop reclone it.
Note this will likely have to happen once more in the future as we move the SMO and c# library to their own repository.
Type of Change
.\tests\manual.pester.ps1)Purpose
Previous pull request introduced a bug as the new LsnSort parameter was being propagated to the underlying call to Get-DbaDbBackupHistory via @PSBoundParameters. Removing from that.
Approach
Commands to test
Screenshots
Learning