Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test-DbaLastBackup - Test MaxSize before CopyFile #7784

Merged
merged 2 commits into from
Sep 18, 2021

Conversation

andreasjordan
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes Test-DbaLastBackup will not respect -MaxSize param #7781 )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

The diff is not very helpfull, as a lot of code moved one idention up due to the removes if construct.

@andreasjordan
Copy link
Contributor Author

Ok, diff is helfull if you ignore whitspace changes.

@andreasjordan
Copy link
Contributor Author

Even more helpfull if you view the diff of the individual commits.

@potatoqualitee
Copy link
Member

Code looks good and my tests worked as well, thank you 👍🏼 💯

@potatoqualitee potatoqualitee merged commit 59df5f5 into development Sep 18, 2021
@potatoqualitee potatoqualitee deleted the 7781_TestDbaLastBackup branch September 18, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test-DbaLastBackup will not respect -MaxSize param
2 participants