Get-DbaAgBackupHistory - Stop even if no exception is raised

[andreasjordan]

Type of Change

• Bug fix (non-breaking change, fixes # )
• New feature (non-breaking change, adds functionality, fixes # )
• Breaking change (effects multiple commands or functionality, fixes # )
• Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
• Adding code coverage to existing functionality
• Pester test is included
• If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
• Nunit test is included
• Documentation
• Build system

Purpose

When no exception is raised by Stop-Function, then the end block continues and tries to connect to an empty list of instances.

Approach

Add a return after Stop-Function

[andreasjordan]

Just found it while helping a user on slack.

Here are the messages before the fix:

WARNING: [23:59:44][Get-DbaAgBackupHistory] Error occurred while establishing connection to MyNode-1 | Access is denied
WARNING: [23:59:59][Get-DbaAgBackupHistory] Error occurred while establishing connection to MyNode-2 | Access is denied
WARNING: [23:59:59][Get-DbaAgBackupHistory] No instances with availability group named 'XXXXX' found, so finishing without results.
Get-DbaDbBackupHistory : Cannot bind argument to parameter 'SqlInstance' because it is an empty array.
At C:\Program Files\WindowsPowerShell\Modules\dbatools\1.0.142\functions\Get-DbaAgBackupHistory.ps1:195 char:58
+ ...  $AgResults = Get-DbaDbBackupHistory -SqlInstance $serverList @PSBoun ...
+                                                       ~~~~~~~~~~~
    + CategoryInfo          : InvalidData: (:) [Get-DbaDbBackupHistory], ParameterBindingValidationException
    + FullyQualifiedErrorId : ParameterArgumentValidationErrorEmptyArrayNotAllowed,Get-DbaDbBackupHistory

[andreasjordan]

Failed test not related to command.

[potatoqualitee]

Makes sense, looks good! Thanks so much.