Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the property name in the 2nd example. #7270

Merged
merged 1 commit into from
May 1, 2021
Merged

Correct the property name in the 2nd example. #7270

merged 1 commit into from
May 1, 2021

Conversation

micxkoz
Copy link
Contributor

@micxkoz micxkoz commented Apr 30, 2021

In the 2nd example the Count property is always 1.
The correct property in the example should be Total or TotalCount. I have chosen Total.

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (effects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

@micxkoz
Correct the property name in the 2nd example.
1ad79f0 
The Count property is always 1.
The correct property should be Total or TotalCount. I have chosen Total.
jpomfret
jpomfret approved these changes May 1, 2021
View reviewed changes
Copy link
Collaborator

@jpomfret jpomfret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix ❤️

@jpomfret jpomfret merged commit 7d0b20f into dataplat:development May 1, 2021
@micxkoz micxkoz deleted the Measure-DbaDbVirtualLogFile_correct_examples branch May 3, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpomfret jpomfret jpomfret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micxkoz @jpomfret