Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to add export functions for Roles #5954

Merged
merged 10 commits into from
Aug 14, 2019
Merged

Changes to add export functions for Roles #5954

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7ec8786
Changes to add export functions for Roles
sqllensman Aug 10, 2019
02f97fc
Fixing Issues with Offline databases , adding Try Catch
sqllensman Aug 10, 2019
dba2f85
uncaught exception
potatoqualitee Aug 11, 2019
118767c
Revert "uncaught exception"
potatoqualitee Aug 11, 2019
14929e1
Changes to exclude unsupported versions and AzureSqlDb
sqllensman Aug 12, 2019
c51265f
Formatting
sqllensman Aug 12, 2019
10621c6
Merge branch 'SqlSat866' of https://github.com/sqllensman/dbatools in…
sqllensman Aug 12, 2019
d27374d
Merge branch 'development' into pr/5954
potatoqualitee Aug 12, 2019
16dfb24
Adding exclusion for databases in CompatibilityLevel 80 or lower
sqllensman Aug 13, 2019
f4fe9fd
Merge branch 'SqlSat866' of https://github.com/sqllensman/dbatools in…
sqllensman Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "uncaught exception" 
This reverts commit dba2f85.
  • Loading branch information
@potatoqualitee
potatoqualitee committed Aug 11, 2019
commit 118767c3739eda862ec1f0f1577d8f0e8edb5e60
9 changes: 2 additions & 7 deletions functions/Test-DbaConnection.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,13 +112,8 @@ function Test-DbaConnection {
Write-Message -Level Verbose -Message "Testing ping to $($instance.ComputerName)"
$ping = New-Object System.Net.NetworkInformation.Ping
$timeout = 1000 #milliseconds

try {
$reply = $ping.Send($instance.ComputerName, $timeout)
$pingable = $reply.Status -eq 'Success'
} catch {
$pingable = $false
}
$reply = $ping.Send($instance.ComputerName, $timeout)
$pingable = $reply.Status -eq 'Success'

try {
$server = Connect-SqlInstance -SqlInstance $instance.FullSmoName -SqlCredential $SqlCredential
Expand Down