Alert category #5854
Merged
Alert category #5854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ohhh shoooooo! thank you 🙇♀ |
wsmelton
reviewed
Jul 3, 2019
wsmelton
reviewed
Jul 3, 2019
| [parameter(Mandatory, ValueFromPipeline)] | ||
| [DbaInstance[]]$SqlInstance, | ||
| [PSCredential]$SqlCredential, | ||
| [string[]]$Category, |
There was a problem hiding this comment.
Suggested change
| [string[]]$Category, | |
| [object[]]$Category, |
@potatoqualitee we used to do these as object types for TEPP, are we still shooting for that?
There was a problem hiding this comment.
it should be string, we generally moved away from object after we started doing InputObject, tho there are exceptions. we can shoot for tepp but it's not required. it's sort of a pain in the butt so i stopped 😅
wsmelton
reviewed
Jul 3, 2019
|
As all of these issues are inherited from the AgentJobSchedule functions I will update both these new functions and the AgentJobSchedule functions. Also should I be adding piping support so that results of the Get functions can be piped to Remove functions? |
|
that would be great and appreciated. thank you, patrick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Purpose
In order to fix one of issues of #5376, namely scripting out alert categories it is necessary to add the functions to Add, Remove or Retrieve Alert Categories in SQL Agent. (similar to Job Categories)
Also fixed minor formatting issues in the AgentJobCategory functions
Commands to test
Get-DbaAgentAlertCategory
New-DbaAgentAlertCategory
Remove-DbaAgentAlertCategory
New-DbaAgentJobCategory
Remove-DbaAgentAlertCategory