Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export-DbaDbTableData, shouldprocess #5727

Merged

Conversation

niphlod
Copy link
Contributor

@niphlod niphlod commented Jun 11, 2019

Type of Change

  • Bug fix (non-breaking change, fixes #)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Due to lack of straight possibility to check within the callee if shouldprocess is invoked in the caller, we still need to decorate the caller with an appropriate shouldprocess... till it gets sorted out this just changes the warning you got before from export-dbascript with one coming straight from ExportDbadbTableData.

@potatoqualitee
Copy link
Member

😍

@potatoqualitee
Copy link
Member

this as well!

@potatoqualitee potatoqualitee merged commit cefade7 into dataplat:prerelease Jun 12, 2019
@niphlod niphlod deleted the pssa/Export-DbaDbTableData branch September 1, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants