Change DATEDIFF function datepart #5492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently ElapsedMinutes computed column uses ss as the datepart for the DATEDIFF function. This does returns elapsed seconds rather than minutes. Changed to mi datepart to return accurate elapsed minutes.
|
awesome! changes make sense. thanks so much 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ElapsedMinutes computed column uses ss as the datepart for the DATEDIFF function in Get-DbaSsisExecutionHistory.ps1. This returns elapsed seconds rather than minutes. Changed to mi tsql datepart to return accurate elapsed minutes.
Type of Change
Change the seconds datepart in Get-DbaSsisExecutionHistory.ps1 to return minutes instead as computed column in query is explicitly called ElapsedMinutes.