Fix Set-DbaNetworkCertificate not granting permissions to private key #5417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Purpose
On a Windows Server 2016 (version 1607, Build 1439.2848) server,
Set-DbaNetworkCertificate
does not grant permissions to the private key.Approach
This appears to be because the
PrivateKey
property of the certificate is$null
, and thePrivateKey
is used to populate the path to the underlying certificate file.Added a check to see if
PrivateKey
is null, and if it is use a different method to determine the underlying file. Also added a check to be sure that$KeyFullPath
is a valid path to a file and abort if it isn't.Commands to test
Screenshots
Learning