Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Integration Tests for Find- cmdlets #5384

Merged
merged 5 commits into from
Apr 20, 2019

Conversation

joshcorr
Copy link
Contributor

@joshcorr joshcorr commented Apr 18, 2019

Type of Change

  • Bug fix (non-breaking change, fixes Test all the Find- cmdlets #4982 )
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Include Tests for Find- cmdlets that previously had 0 code coverage.

Approach

Either creating objects that need to be retrieved by a cmdlet, or executing the cmdlet with existing information

Commands to test

Invoke-Pester .\Find-DbaAgentJob.Tests.ps1
Invoke-Pester .\Find-DbaCommand.Tests.ps1
Invoke-Pester .\Find-DbaTrigger.Tests.ps1
Invoke-Pester .\Find-DbaUserObject.Tests.ps1
Invoke-Pester .\Find-DbaStoredProcedure.Tests.ps1
Invoke-Pester .\Find-DbaView.Tests.ps1

@potatoqualitee
Copy link
Member

ohhhh heyyy! thank you 💯 💯 💯

@joshcorr joshcorr marked this pull request as ready for review April 20, 2019 04:18
@joshcorr
Copy link
Contributor Author

Believe the last error was a AppVeyor issue. I did most of the cmdlets on the Issue. The ones I didn't complete seem to be doing some very specific Tsql or AD related tasks. Considered reaching out to the Authors of those cmdlets to build tests for these ones since they are more familiar with the code.

@potatoqualitee
Copy link
Member

Thanks so very much, Josh 💯 🙇

@potatoqualitee potatoqualitee merged commit 84e469c into dataplat:development Apr 20, 2019
@joshcorr joshcorr deleted the add-find-tests branch April 20, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test all the Find- cmdlets
2 participants