Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect-DbaInstance enhancements #5205

Merged
merged 17 commits into from
Mar 15, 2019
Merged

Connect-DbaInstance enhancements #5205

merged 17 commits into from
Mar 15, 2019

Conversation

potatoqualitee
Copy link
Member

@potatoqualitee potatoqualitee commented Mar 15, 2019

  • make it work better with azure
  • add netport for future potential fix in dbatools library

// the extra checks break azure by enumerating, causing a new
// connection and sometimes altering the connection string
// so let's just accept computername

AzureSqlDb only runs on 1433 so it shouldn't need to parse the port
// the extra checks break azure by enumerating, causing a new
// connection and sometimes altering the connection string
// so let's just accept computername

AzureSqlDb only runs on 1433 so it shouldn't need to parse the port
@potatoqualitee
Copy link
Member Author

one failure due to appveyor 🙄

@potatoqualitee potatoqualitee changed the title Invokedbaquery updates Connect-DbaInstance enhancements Mar 15, 2019
@potatoqualitee potatoqualitee merged commit 4fcfeac into development Mar 15, 2019
@potatoqualitee potatoqualitee deleted the invokedbaquery branch March 15, 2019 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant