Rename-DbaDatabase, round #3 #2735
Conversation
functions/Rename-DbaDatabase.ps1
Outdated
|
|
||
| dbatools PowerShell module (https://dbatools.io, clemaire@gmail.com) | ||
| Copyright (C) 2016 Chrissy LeMaire | ||
| This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. |
There was a problem hiding this comment.
Need to update this to current license statement
|
Just curious if the Shouldn't that be using Just one more small thing...if an operation requires setting the database offline and that fails I don't think it is best to keep going with the changes and leaving "low hanging fruit" like "You are in charge of moving the files to the new location". I obviously don't know how to use this one 😝 I think overall it is a good first round but believe it is going to be too easy for folks to dork up their databases with those placeholders. We will likely need a good blog post or something to point folks at starting out. Then as we get more folks using it figure out how (or if we can) fine tune it. |
|
I'm up for merging it but will leave that to @potatoqualitee ... I mean we have to start somewhere and just wait for feedback to come in on it. |
|
yeah, apparently no better ideas came around during code review so we should hear from users pretty soon. The original requested feature-set is in. Lemme fix the license and try to figure out your issue, then I think it can be merged. |
|
I'd love to merge! Then we'll ask for some testers. @wsmelton - feel free to merge and ping me once you and niph are ready. then i'll add it to psd1 |
|
I would say we push this one out as a "beta" type thing, get folks using it in their test environments and then have them offer feedback/suggestions. Especially since we cannot test for every possible scenario of file configurations in a database. |
|
on the "leave the low hanging fruit" theme, unfortunately it's kinda chicken/egg problem: nothing can be moved until the db is put offline (files are locked if db is online), and there's no way to pre-check if a move can be done. Maybe it should try to rollback the changes, but it's not that simple. @wsmelton : the error shown seems to point out you can't |
|
Yesssss thanks @niphlod ! Adding this and alerting Rob Volk who originally requested it. |
3 participants
Type of Change
Purpose
Reissue of #2442, which is a reissue of #2030 . Please merge ASAP, keeping tracks is starting to be extremely difficult.