Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the gcc, gxx, pybind to the env file. Preparing for packaging #527

Closed
wants to merge 1 commit into from

Conversation

DomInvivo
Copy link
Collaborator

Changelogs

  • Changing the env.yml file to contain all the gcc requirements
  • Updating the install instructions

Issues to resolve:

  • Currently only supports linux x64 because the gcc and gxx do not work in the env file, we need to specify gcc_linux-64 and gxx_linux-64. Ideally, we want to support Win64, WinARM, Linux64, LinuxARM, Mac64, MacARM
  • Weirdly, gcc --version and gxx --version don't appear in the command line. We need to rename their folders ln -s MY_ENV_PATH/bin/x86_64-conda-linux-gnu-gcc MY_ENV_PATH/bin/gcc, same with gxx.
  • When in dev mode, we need to build graphium/graphium_cpp separately with pybind11, then install it with pip install -e graphium_cpp --no-deps. Ideally, all should be built and installed from directly pip install -e . --no-deps.

@DomInvivo DomInvivo added this to the Graphium 3.0 milestone Sep 25, 2024
@DomInvivo
Copy link
Collaborator Author

@Andrewq11 , are you working on that branch? I assume you have your own branch for this, and we can close this one

@Andrewq11
Copy link
Collaborator

Yes I have my own branch for the packaging work. Feel free to close this.

@Andrewq11
Copy link
Collaborator

Closing PR as work has evolved on another branch

@Andrewq11 Andrewq11 closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants