-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyright headers. #495
Merged
Copyright headers. #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DomInvivo
added
documentation
Improvements or additions to documentation
ASAP priority
Major thing to do or fix
labels
Dec 20, 2023
DomInvivo
requested review from
michalkoziarski,
jstlaurent,
joao-alex-cunha,
shenyangHuang,
lujiarui,
engmubarak48,
WenkelF,
luis-mueller,
callumm-graphcore,
blazejba and
kerstink-GC
December 20, 2023 04:54
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
==========================================
+ Coverage 71.35% 71.54% +0.18%
==========================================
Files 94 93 -1
Lines 8718 8702 -16
==========================================
+ Hits 6221 6226 +5
+ Misses 2497 2476 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
blazejba
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG on the behalf of Graphcore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelogs
.py
file.sh
fileLICENSE
fileChecklist:
This PR is simply to add a Copyright notice everywhere, and update the LICENSE file. There's a lot of changes but it's quite simple. I'm tagging lots of reviewers for visibility.
About 90-95% of the file headers are:
With 2
.sh
files modified to attribute only to Graphcore and ~10.py
files modified to attribute only to Valence. To be safe, every file that was modified between 5 and 18 months ago were attributed to everyone.I also listed the most important Academic collaborators in the
LICENSE
file