Fix samples_seen logging
#483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumm-graphcore
changed the title
samples_seen loggingsamples_seen logging
Codecov Report
@@ Coverage Diff @@
## main #483 +/- ##
==========================================
- Coverage 71.45% 69.64% -1.81%
==========================================
Files 93 93
Lines 8512 8519 +7
==========================================
- Hits 6082 5933 -149
- Misses 2430 2586 +156
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DomInvivo
approved these changes
Oct 26, 2023
| @@ -70,15 +70,12 @@ def get_replication_factor(cfg): | |||
|
|
|||
|
|
|||
| def get_gradient_accumulation_factor(cfg): | |||
| """ | |||
| WARNING: This MUST be called after accelerator overrides have been applied | |||
There was a problem hiding this comment.
Can you specify what is the accelerator overrides? Is this a function? Where is it?
There was a problem hiding this comment.
These are applied in load_accelerator, I'll clarify the comment
callumm-graphcore
changed the title
samples_seen loggingsamples_seen logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelogs
deviceIterationsin logging ofsamples_seenChecklist:
feature,fixortest(or ask a maintainer to do it for you).discussion related to that PR