Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix strategy argument for trainer #447

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix strategy argument for trainer #447

merged 1 commit into from
Aug 28, 2023

Conversation

maciej-sypetkowski
Copy link
Collaborator

Changelogs

  • Fix trainer.trainer.strategy. Previously the argument was passed twice for Trainer construction and thus error.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

@maciej-sypetkowski maciej-sypetkowski added the bug Something isn't working label Aug 27, 2023
@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #447 (0170dcc) into main (95ece97) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #447   +/-   ##
=======================================
  Coverage   65.37%   65.37%           
=======================================
  Files          92       92           
  Lines        8253     8253           
=======================================
  Hits         5395     5395           
  Misses       2858     2858           
Flag Coverage Δ
unittests 65.37% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
ipu 49.14% <ø> (ø)

@DomInvivo DomInvivo merged commit e424f21 into main Aug 28, 2023
7 checks passed
@maciej-sypetkowski maciej-sypetkowski deleted the fix-strategy branch August 28, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants