Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric fix: auroc avpr and metric averaging #427

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Metric fix: auroc avpr and metric averaging #427

merged 3 commits into from
Aug 2, 2023

Conversation

zhiyil1230
Copy link
Contributor

Changelogs

  • enumerate the changes of that PR.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

num_classes: 5
task: multiclass
target_to_int: True
target_nan_mask: -1000
ignore_index: -1000
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DomInvivo Had to use ignore_index for l1000_vcap and l1000_mcf7 as target_nan_mask gives nan. But for pcba target_nan_mask is used as you suggested.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the workaround that you found to use ignore_index with target_nan_mask

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #427 (7903fb0) into main (6006da5) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
- Coverage   66.91%   66.87%   -0.04%     
==========================================
  Files          82       82              
  Lines        7819     7823       +4     
==========================================
  Hits         5232     5232              
- Misses       2587     2591       +4     
Flag Coverage Δ
unittests 66.87% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
ipu 49.14% <ø> (ø)

@DomInvivo DomInvivo merged commit 2e3d0bf into main Aug 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants