-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pcqm4m changes with mpnn and gps++ configs, fix run_validation_test.py #419
Conversation
Codecov Report
@@ Coverage Diff @@
## main #419 +/- ##
==========================================
+ Coverage 63.89% 66.77% +2.87%
==========================================
Files 82 82
Lines 7813 7819 +6
==========================================
+ Hits 4992 5221 +229
+ Misses 2821 2598 -223
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move to the new type of compositional configurations, using hydra?
I've modified the pcqm mpnn and gpspp configs to hydra and tested ok. For the largemix configs, I think @joao-alex-cunha is working on it. So here it is just a simple fix. |
Changelogs
Checklist:
feature
,fix
ortest
(or ask a maintainer to do it for you).discussion related to that PR
The mpnn and gpss++ are not up to date with the recent changes. Update them accordingly. Test run with 8000 samples look fine, loss decreasing.