Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label dtype error #369

Merged
merged 6 commits into from
Jun 28, 2023
Merged

Fix label dtype error #369

merged 6 commits into from
Jun 28, 2023

Conversation

callumm-graphcore
Copy link
Collaborator

Changelogs

  • Track dtypes of labels to prevent dtype mismatch error on IPU

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

@callumm-graphcore callumm-graphcore added the fix PR that fixes an issue label Jun 28, 2023
@callumm-graphcore callumm-graphcore linked an issue Jun 28, 2023 that may be closed by this pull request
Fix dtype bug for largemix labels #358
Closed
@callumm-graphcore callumm-graphcore merged commit 0d9e656 into main Jun 28, 2023
@DomInvivo DomInvivo deleted the fix-label-dtype-error branch July 21, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DomInvivo DomInvivo DomInvivo approved these changes

Assignees
No one assigned
Labels
fix PR that fixes an issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix dtype bug for largemix labels
2 participants
@callumm-graphcore @DomInvivo