Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some fixes: keys() and use normalization flag on val and test for baseline configs #367

Merged
merged 7 commits into from
Jun 29, 2023
Merged

some fixes: keys() and use normalization flag on val and test for baseline configs #367

merged 7 commits into from
Jun 29, 2023

Conversation

zhiyil1230
Copy link
Contributor

Changelogs

  • enumerate the changes of that PR.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

@zhiyil1230 zhiyil1230 changed the title minor fixes some fixes: keys() and use normalization flag on val and test for baseline configs Jun 27, 2023
@callumm-graphcore
Copy link
Collaborator

I would strongly suggest that we make the keys vs keys() thing for the PyG batches a function, rather than just making a bunch of independent changes

@zhiyil1230 zhiyil1230 merged commit 2257638 into main Jun 29, 2023
@DomInvivo DomInvivo deleted the minor_fixes branch July 21, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DomInvivo DomInvivo DomInvivo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiyil1230 @callumm-graphcore @DomInvivo