Merging configs #362
Merged
Merging configs #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyil1230
approved these changes
Jun 20, 2023
|
@zhiyil-graphcore , before I merge, can you double-check that it works well? |
zhiyil1230
reviewed
Jun 20, 2023
| if args.config is not None: | ||
| CONFIG_FILE = args.config | ||
| args, unknown_args = parser.parse_known_args() | ||
| cfg = load_yaml_config(CONFIG_FILE, MAIN_DIR, unknown_args) | ||
|
|
There was a problem hiding this comment.
I think it would be more convenient to add these two lines so that we could load config from command line:
` if args.config is not None:
CONFIG_FILE = args.config`
I tested the large mix configs, they run ok with merged dicts. |
zhiyil1230
reviewed
Jun 20, 2023
| @@ -172,7 +185,7 @@ architecture: | |||
|
|
|||
| gnn: # Set as null to avoid a post-nn network | |||
| in_dim: 64 # or otherwise the correct value | |||
| out_dim: &gnn_dim 128 | |||
| out_dim: &gnn_dim 64 | |||
There was a problem hiding this comment.
We might need a out_dim of 128 for gcn so that the model size for the 3 models (gcn, gin, gine) stay around 170k. It's not a big deal if this is more of a sample script as we still have those baseline script to reproduce the results reported on paper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelogs
Checklist:
feature,fixortest(or ask a maintainer to do it for you).discussion related to that PR