Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightning v2 #323

Merged
merged 25 commits into from
Jun 23, 2023
Merged

Lightning v2 #323

merged 25 commits into from
Jun 23, 2023

Conversation

joao-alex-cunha
Copy link
Collaborator

NOT TO BE LANDED YET

Adding support for Lightning 2.+

Removes most changes needed in the custom fork being used for IPUs.
Training with the model weights and data in FP 16 precision is referred in Lightning as "16-true".

@joao-alex-cunha joao-alex-cunha changed the title WIP: Lightning v2 Lightning v2 Jun 1, 2023
@joao-alex-cunha
Copy link
Collaborator Author

should be ready to review.
There's a lot of file changes. But you can ignore the notebooks, since the PR is just fixing the imports but for the most part they are not even used.

DomInvivo
DomInvivo approved these changes Jun 23, 2023
View reviewed changes
Copy link
Collaborator

@DomInvivo DomInvivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just fix the CI, but everything is perfect

@DomInvivo DomInvivo merged commit 2566355 into main Jun 23, 2023
@notion-workspace
Copy link

Improve memory usage

@DomInvivo DomInvivo deleted the lightning_v2 branch July 21, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DomInvivo DomInvivo DomInvivo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joao-alex-cunha @DomInvivo