Skip to content

fix: add lasso colors for atom_indices #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

OleinikovasV
Copy link

@OleinikovasV OleinikovasV commented Mar 7, 2025

Changelogs

Adds color to lasso when atom_indices are specified in addition or instead of smarts_list.


Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs below.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR
#233

label: bug

Copy link
Contributor

@zhu0619 zhu0619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you for fixing this! @OleinikovasV

@zhu0619
Copy link
Contributor

zhu0619 commented Mar 14, 2025

@OleinikovasV Please lint and format the changes.

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.22%. Comparing base (3864d9d) to head (cc4a466).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #232      +/-   ##
==========================================
+ Coverage   90.26%   92.22%   +1.96%     
==========================================
  Files          46       46              
  Lines        3881     3883       +2     
==========================================
+ Hits         3503     3581      +78     
+ Misses        378      302      -76     
Flag Coverage Δ
unittests 92.22% <100.00%> (+1.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@OleinikovasV
Copy link
Author

@OleinikovasV Please lint and format the changes.

@zhu0619 , AFAIU, the lint and test errors are not related to the changes I made to this repo, but instead something to do with CI versioning?
The linter is identifying issues with the files that are not touched by this PR.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants