Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure paths are string in datamol.fs.glob #210

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Make sure paths are string in datamol.fs.glob #210

merged 1 commit into from
Sep 4, 2023

Conversation

hadim
Copy link
Contributor

@hadim hadim commented Sep 4, 2023 •
edited
Loading

Changelogs

  • Make sure paths are string in datamol.fs.glob

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs below.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

@hadim hadim added the fix label Sep 4, 2023
@hadim hadim merged commit 22b5bb0 into main Sep 4, 2023
15 checks passed
@hadim hadim deleted the pathstr branch September 4, 2023 13:10
@cwognum cwognum mentioned this pull request Nov 10, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hadim