Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont import sasscorer by default #102

Merged
merged 4 commits into from
May 13, 2022
Merged

dont import sasscorer by default #102

merged 4 commits into from
May 13, 2022

Conversation

hadim
Copy link
Contributor

@hadim hadim commented May 13, 2022

Checklist:

  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added or an existing one is deleted.
  • Added a news entry.
    • copy news/TEMPLATE.rst to news/my-feature-or-branch.rst) and edit it.

@hadim hadim requested review from maclandrol and MichelML May 13, 2022 15:28
Copy link
Member

@maclandrol maclandrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep works

@MichelML
Copy link
Contributor

I guess the failing tests is expected at the moment, seems unrelated.

@hadim
Copy link
Contributor Author

hadim commented May 13, 2022

I guess the failing tests is expected at the moment, seems unrelated.

Yup a boring regression on the Github action we use. Will fix before merging.

Thanks guys.

@hadim
Copy link
Contributor Author

hadim commented May 13, 2022

GA bug being addressed at mamba-org/provision-with-micromamba#54

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #102 (6ebf205) into main (a4b7cc1) will decrease coverage by 0.03%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   83.77%   83.73%   -0.04%     
==========================================
  Files          48       48              
  Lines        3420     3425       +5     
==========================================
+ Hits         2865     2868       +3     
- Misses        555      557       +2     
Flag Coverage Δ
unittests 83.73% <75.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datamol/descriptors/descriptors.py 94.02% <75.00%> (-2.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b7cc1...6ebf205. Read the comment docs.

@hadim hadim merged commit c4f21bd into main May 13, 2022
@hadim hadim deleted the pypi-bug branch May 13, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants