Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python-package.yml #127

Merged
merged 1 commit into from
May 2, 2023

Conversation

mr-fuller
Copy link
Contributor

@mr-fuller mr-fuller commented Jan 31, 2023

I did some digging and it looked like maybe the workflows need to be updated, possibly due to the switch to Node16 instead of Node12 (https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/). It looked like the workflows were failing to even install python before running any tests on the package code.

I don't know anything about the workflows or how to test if this fixes anything. I just changed a few things based on the starter workflow from github's python package guide (https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python).

Edit: the workflows failing in (#126) had errors about not finding python versions and warnings about the deprecation. I think the changes I am suggesting only address the warnings, not the errors.

Edit 2: based on this comment/thread (actions/setup-python#162 (comment)), the python 3.5 and 3.6 errors might be related to the runs-on:ubuntu-latest setting, as 3.5 and 3.6 don't include files for ubuntu version 22.04 (in the list of available versions https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json).

@mr-fuller mr-fuller marked this pull request as ready for review February 15, 2023 17:59
@fgregg
Copy link
Member

fgregg commented May 2, 2023

thanks!

@fgregg fgregg merged commit b3d7c18 into datamade:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants