MailKit conversion redux#79
Merged
Merged
Conversation
Closed
Contributor
Author
|
Note - the additional changes in #78 fix the SmtpOptions implementation not being set as Lazy and an issue with To address parsing, but this was the most natural split between the MailKit implementation and subsequent changes. If I went past this commit, it would pull in mail host fallback and delivery using DNS. |
nblumhardt
reviewed
Aug 16, 2021
| (new BodyBuilder() {HtmlBody = body}).ToMessageBody())); | ||
|
|
||
| if (!result.Success) | ||
| throw result.Errors; |
Member
There was a problem hiding this comment.
This will cause the loss of the original stack trace; I might head towards making Send() throw, but I'll merge now to avoid more churn on this long and storied PR :-)
Contributor
Author
There was a problem hiding this comment.
No worries. I do have handling for this in further commits - will send a new PR for the next set.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion in #78