This repository was archived by the owner on Mar 25, 2022. It is now read-only.
Remove dynamic require #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm using this patch, thank you :) looking forward to merge by maintainers |
|
For maintainers, thanks for this lib, just wanted to add that dynamic require are not considered module friendly, especially when you develop a library for the npm ecosystem, I think this PR need to be merged ASAP. |
|
UP! Please merge this one! And ty for this lib! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell this dynamic require doesn't need to be dynamic. Currently it is causing issues with some bundlers like esbuild, which do not include the reserved.js file in the final bundle due to the dynamic import.
Should fix
#28
#29