Enable running iter_annexworktree() on just-Git repos
#673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an obscure `iterable did not yield matching item for route-in item, cardinality mismatch?` error when attempting such a query before. This fix is a choice. An alternative could be to error out in this case. I went for this approach, because the test is cheap, and not much more expensive than catching the previous error in a precise manner. With this change, the items of the underlying `gitworktree` iterator are yielded, after funneling them through the `annexworktree` iteration post-processing to ensure type-alignment and other (future) side-effect. The outcome is therefore identical to items in Git yielded from an annex-enabled repository. Closes: datalad#670
|
Test failure is #674 |
It is likely useful to collect such functionality in a dedicated place and a reusable form. Running such code repeatedly might be wasteful, so eventually some kind of capability inference/caching layer could be built. However, such layer would still use these basic helpers and providing them avoid forcing client code to use heavy cannons in cases where they are not needed.
See comments inside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an obscure
iterable did not yield matching item for route-in item, cardinality mismatch?error when attempting such a query before.
This fix is a choice. An alternative could be to error out in this case. I went for this approach, because the test is cheap, and not much more expensive than catching the previous error in a precise manner.
With this change, the items of the underlying
gitworktreeiterator are yielded, after funneling them through theannexworktreeiteration post-processing to ensure type-alignment and other (future) side-effect. The outcome is therefore identical to items in Git yielded from an annex-enabled repository.Closes: #670
TODO: