Discontinue usage of Runner functionality for Git calls
#632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `call_git_success()` learned to capture, but withold, outputs - `call_git_[one]line[s]()` learned to accept command input
The new implementation uses the lean `call_git...()` utilities directly. It also avoids the relatively heavy-handed environment patching mechanism in the runner, in favor of the new lean `patched_env` context manager. This is OK, because the git remote helper runs in its own process. Ping datalad#541
This was referenced Feb 7, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
==========================================
+ Coverage 93.01% 93.02% +0.01%
==========================================
Files 170 171 +1
Lines 11907 11932 +25
Branches 1795 1805 +10
==========================================
+ Hits 11075 11100 +25
+ Misses 644 643 -1
- Partials 188 189 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elevates the
call_git..()helpers to have enough functionality to replace the observed usage patterns forGitRepo.call_git..()and otherRepocentric runner call pattern.All these are replaced with
call_git..()utility fromdatalad-next.Closes #541