Add ZipArchiveOperations with tests
#578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changeset an implementation `ArchiveOperations` for ZIP files. It makes use of `datalad_next.iter_collections.zipfile.iter_zip` to implement iteration. The tests include a pytest-fixture called `structured_sample_zip`, which reports on a sample ZIP from the `sample_zip` fuxture, with its properties readily accessible. It should likely replace `sample_zip`.
Also remove needless verbosity by using already present "shortcut" names.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 92.55% 92.62% +0.06%
==========================================
Files 145 147 +2
Lines 10570 10678 +108
Branches 1579 1600 +21
==========================================
+ Hits 9783 9890 +107
Misses 614 614
- Partials 173 174 +1 ☔ View full report in Codecov by Sentry. |
mih
force-pushed
the
ziparchive
branch
2 times, most recently
from
a1b7d75 to
971d062
Compare
`ZipFile.getinfo()` wants an archive name only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset an implementation
ArchiveOperationsfor ZIP files. It makes use ofdatalad_next.iter_collections.zipfile.iter_zipto implement iteration.The tests include a pytest-fixture called
structured_sample_zip, which reports on a sample ZIP from thesample_zipfuxture, with its properties readily accessible. It should likely replacesample_zip.Replaces #407