EnsureRemoteName and uplift parameter validation in create-sibling-webdav
#577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds tests for `EnsureRemoteName`. A sister class `EnsureSiblingName` is also provided. It does the exact same thing, but calls a "remote" a "sibling. Matter of taste. Closes datalad#193
Use `EnsureRemoteName` for sibling and storage sibling parameters. Now immediately checks for conflicting remote name, when `existing='error'` and not going recursive. In this case, the command would error later, and in a more expensive way. Now this situation is caught during command validation, and reported properly, and jointly with others.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
- Coverage 92.58% 92.55% -0.03%
==========================================
Files 145 145
Lines 10499 10570 +71
Branches 1563 1579 +16
==========================================
+ Hits 9720 9783 +63
- Misses 606 614 +8
Partials 173 173 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the streamlined version of #324
Closes #193