SSH implementation and test upgrade #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mih
force-pushed
the
appveyor
branch
12 times, most recently
from
7d17ef1 to
0092fc7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
==========================================
+ Coverage 91.57% 92.68% +1.10%
==========================================
Files 142 142
Lines 10421 10465 +44
Branches 1549 1556 +7
==========================================
+ Hits 9543 9699 +156
+ Misses 711 597 -114
- Partials 167 169 +2 ☔ View full report in Codecov by Sentry. |
mih
force-pushed
the
appveyor
branch
8 times, most recently
from
1fa9be9 to
3f3a10e
Compare
This pulls out a logic implementation that comes from the internals of datalad-core's SSH manager. Closes #571
This allows for flexible setups. The fixtures obey `DATALAD_TESTS_SSH`, and aim at `localhost` by default. However, alternative targets can be configured.
This adopts the setup prepared for `datalad-ria`. On Linux and Windows an SSH-accessible server is deployed via Docker. On Mac ssh-to-self is employed. Closes #563
christian-monch
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Assuming that the type errors would be fixed in #566, this looks good to me.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #563
Closes #571
TODO:
ssh://sshuser@datalad-test-sshd:2222//usr/local/apache2/htdocs/myfileit runsssh datalad-test-sshd. The lack of support comes from_SshCat.