Simplify (subprocess) coverage setup #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous setup was taken from datalad-core. It comes from a time before `pytest`. With `pytest-cov` none of this complexity should be needed anymore. A similar setup has been implemented as part of datalad/datalad-ria#6 Closes datalad#453
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 92.12% 92.07% -0.06%
==========================================
Files 122 122
Lines 9107 9107
Branches 0 1009 +1009
==========================================
- Hits 8390 8385 -5
+ Misses 717 705 -12
- Partials 0 17 +17 ☔ View full report in Codecov by Sentry. |
|
It is not clear to me why there are coverage fluctuations at all, but here is the overview of the PR from codecov:
Important are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous setup was taken from datalad-core. It comes from a time before
pytest. Withpytest-covnone of this complexity should be needed anymore.A similar setup has been implemented as part of
datalad/datalad-ria#6
Closes #453