Skip to content

Spin up httpbin container via pytest fixture #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2023
Merged

Spin up httpbin container via pytest fixture #313

merged 2 commits into from
Mar 11, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 10, 2023

Part of #261.

@jwodder jwodder requested a review from mih as a code owner March 10, 2023 21:07
mih
mih previously approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Maintains behavior, improves implementation. Much appreciated!

Note to self: Continues to ignore the possibility to use docker on windows. Watch failure pattern with public instance now and add later, if necessary.

@mih
Copy link
Member

mih commented Mar 11, 2023

Macos test on appveyor now need protection against missing docker again.

@mih
Reintroduce protecting docker image deployment on appveyor
e37f86f 
MacOS doesn't have it, and I prefer to have this all clearly
indicated with flags on each run.
@mih mih merged commit 166a0a7 into main Mar 11, 2023
@mih mih deleted the gh-261 branch March 11, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic left review comments

@mih mih mih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwodder @mih @yarikoptic