Skip to content

public url would be https while docker http, so allow for both in test matching #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2023
Merged

public url would be https while docker http, so allow for both in test matching #312

merged 1 commit into from
Mar 11, 2023

Conversation

yarikoptic
Copy link
Member

Fixes #261

@yarikoptic yarikoptic requested a review from mih as a code owner March 10, 2023 20:04
@yarikoptic yarikoptic mentioned this pull request Mar 10, 2023
Closed
mih
mih approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@mih mih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! Thx for catching that!

@mih mih enabled auto-merge March 10, 2023 20:21
@mih mih added this pull request to the merge queue Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +4.11 🎉

Comparison is base (b6096c9) 87.62% compared to head (1ae59d4) 91.73%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   87.62%   91.73%   +4.11%     
==========================================
  Files          80       80              
  Lines        7080     7238     +158     
==========================================
+ Hits         6204     6640     +436     
+ Misses        876      598     -278
Impacted Files Coverage Δ
datalad_next/annexremotes/tests/test_uncurl.py 93.78% <ø> (+0.56%) ⬆️

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 10, 2023
@yarikoptic
Copy link
Member Author

I need to learn what is that fancy merge queue and how it would make my life better (besides extra commotion in emails). Is it to batch multiple PRs to be merged at once and to minimize CI runs?

@mih mih added this pull request to the merge queue Mar 11, 2023
@mih mih removed this pull request from the merge queue due to a manual request Mar 11, 2023
@mih mih merged commit a886e64 into main Mar 11, 2023
@mih mih deleted the bf-261 branch March 11, 2023 06:00
@mih
Copy link
Member

mih commented Mar 11, 2023

It can be used to stack PR, such that a requirement to be uptodate wrt to a base branch need not be managed with manual action. However, it seems codecov was not able to send a response in 8h...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mih mih mih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

has been failing testing in datalad core for abit
2 participants
@yarikoptic @mih