Rectify OR and AND of Constraints and AltConstraints
#292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both implementations performed in-place modifications of the left-side constraint. This is not appropriate, because it matches the semantics of `__iand__` and `__ior__`, rather than `__and__` and `__or__`. This change move away from the in-place implementation and simply returns a new instance. This is cheap. There is no implementation of `__iadd__` and `__ior__`, although simply renaming the methods would have been enough. There is no need for it, and it can be done whenever there is actual demand. Closes datalad#291
It is shorter, it is clearer. The old class names stay for backward compatibility. Two more changes: - the new classes are now also exposed from `__init__.py` - superfluous comments have been removed Closes datalad#185
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both implementations performed in-place modifications of the left-side constraint. This is not appropriate, because it matches the semantics of
__iand__and__ior__, rather than__and__and__or__.This change move away from the in-place implementation and simply returns a new instance. This is cheap.
There is no implementation of
__iadd__and__ior__, although simply renaming the methods would have been enough.There is no need for it, and it can be done whenever there is actual demand.
Closes #291