Skip to content

Do credential type detection for reporting #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Do credential type detection for reporting #257

merged 1 commit into from
Feb 23, 2023

Conversation

mih
Copy link
Member

@mih mih commented Feb 23, 2023

For now the only scenario is a credential specification that comprises a token-property only.

However, with the recent RF there is now a dedicated piece of code that could be extended arbitrarily to support additional scenarios.

❯ DATALAD_CREDENTIAL_MIKE_TOKEN=some dl -f json_pp credentials get mike
{
  "action": "credentials",
  "cred_secret": "some",
  "cred_type": "token",
  "name": "mike",
  "status": "ok"
}

Closes #251

For now the only scenario is a credential specification that comprises
a token-property only.

However, with the recent RF there is now a dedicated piece of code that
could be extended arbitrarily to support additional scenarios.

Closes datalad#251
@mih
Copy link
Member Author

mih commented Feb 23, 2023

More green! All the failures are unrelated to this PR.

@mih mih merged commit 705a29e into datalad:main Feb 23, 2023
@mih mih deleted the bf-251 branch February 23, 2023 16:29
@mih mih restored the bf-251 branch February 24, 2023 08:06
@mih mih deleted the bf-251 branch February 24, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better support for lonely token credential specification
1 participant