Skip to content
This repository was archived by the owner on Dec 8, 2023. It is now read-only.

Fixes for codebook deployment #76

Merged
merged 4 commits into from
Jul 22, 2022
Merged

Fixes for codebook deployment #76

merged 4 commits into from
Jul 22, 2022

Conversation

CBroz1
Copy link
Contributor

@CBroz1 CBroz1 commented Jul 21, 2022 •
edited
Loading

  • remove assertion of directory name from notebooks as this won't work on codebook
  • add mention of data directory for codebook
  • move all export items from pipeline to export, include warning for users not using no-curation ephys_mode

@CBroz1 CBroz1 mentioned this pull request Jul 21, 2022
Merged
@CBroz1 CBroz1 requested a review from sidhulyalkar July 21, 2022 22:41
@CBroz1 CBroz1 changed the title [DRAFT] Fixes for codebook deployment Fixes for codebook deployment Jul 21, 2022
@CBroz1 CBroz1 marked this pull request as ready for review July 21, 2022 22:43
@kabilar kabilar self-assigned this Jul 22, 2022
@kabilar kabilar removed the request for review from sidhulyalkar July 22, 2022 14:12
kabilar
kabilar reviewed Jul 22, 2022
View reviewed changes
kabilar
kabilar reviewed Jul 22, 2022
View reviewed changes
kabilar
kabilar approved these changes Jul 22, 2022
View reviewed changes
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CBroz1. Two minor comments above.

@kabilar kabilar added this to the 2022Q3 milestone Jul 22, 2022
@kabilar
Copy link
Collaborator

kabilar commented Jul 22, 2022

Please update changelog.

@CBroz1
Copy link
Contributor Author

CBroz1 commented Jul 22, 2022

Thanks for your review @kabilar. I've updated the changelog and fixed the parallel typo in the ipynb. See comment above regarding changes to export.py

@CBroz1 CBroz1 requested a review from kabilar July 22, 2022 15:47
kabilar
kabilar approved these changes Jul 22, 2022
View reviewed changes
Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CBroz1!

@kabilar kabilar merged commit d4be911 into datajoint:main Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kabilar kabilar kabilar approved these changes

Assignees

@kabilar kabilar

Labels
None yet
Projects
None yet
Milestone
2022Q3
Development

Successfully merging this pull request may close these issues.
2 participants
@CBroz1 @kabilar