Skip to content
This repository was archived by the owner on Dec 8, 2023. It is now read-only.

Update Docker and Compose files. Add pytest fixture. #45

Merged
merged 13 commits into from
Mar 17, 2022

Conversation

kabilar
Copy link
Collaborator

@kabilar kabilar commented Mar 13, 2022

  • Move Docker and Compose files to docker subdirectory
    • git mv wasn't working for docker-compose-dev.yaml so original file is deleted and a new file is created.
  • Add pytest fixture ephys_insertionlocation for NWB export tests

@kabilar kabilar changed the title Add NWB tests Add NWB export pytest Mar 14, 2022
@CBroz1
Copy link
Contributor

CBroz1 commented Mar 15, 2022

Should this PR incorporate everything from PR #18? Will we try to merge this before or after ongoing work linking element-trial?

@kabilar
Copy link
Collaborator Author

kabilar commented Mar 17, 2022

Should this PR incorporate everything from PR #18?

I will go through #18 and incorporate appropriate changes as our approach to the NWB export has changed since #18 was first proposed.

@kabilar
Copy link
Collaborator Author

kabilar commented Mar 17, 2022

Will we try to merge this before or after ongoing work linking element-trial?

Let's merge the changes in this pull request before the work linking element-trial. However, I will not include the NWB export pytests in this pull request.

@kabilar kabilar changed the title Add NWB export pytest Update Docker and Compose files. Add pytest fixture. Mar 17, 2022
@kabilar kabilar marked this pull request as ready for review March 17, 2022 03:25
@kabilar
Copy link
Collaborator Author

kabilar commented Mar 17, 2022

Hi @CBroz1, this pull request is ready for review. Thanks.

@CBroz1 CBroz1 merged commit ab0c034 into datajoint:main Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants