Export to nwb

[bendichter]

No description provided.

[CBroz1]

The gh action buildtest is failing because there was a change to usernames. If you swap dja for anaconda in the dockerfile, as shown here, it should fix the issue.

[bendichter]

@CBroz1 why add a SessionNote table? Wouldn't it be better to just add this as a field of the Session table?

[CBroz1]

@CBroz1 why add a SessionNote table? Wouldn't it be better to just add this as a field of the Session table?

Arguably, SessionDirectory and SessionNote could both be folded into as nullable foreign keys. The thought process here is that not all users will use either, but the central Session table has a lot of downstream connections, so better to keep it as clean as possible. E.g - many use cases will say session_key = (session.Session & 'subject="target"').fetch1("KEY") - We might save some hassle if someone forgets the fetch("KEY") method by only including primary keys.

Thinking it through, maybe SessionDirectory and SessionNote should be part tables of Session?

[bendichter]

@CBroz1 I don't see what you are gaining by making either session_note or session_directory their own tables. It complicates the schema and necessitates more complex queries. I generally think of tables as handling 1-many and many-many relationships. If you have a 1-1 relationship, such as session to session_note, IMO it is better to make a fatter table with nullable fields than add additional tables. These fields would not be keys, so it should not affect any other tables that link to Session.

[CBroz1]

@CBroz1 I don't see what you are gaining by making either session_note or session_directory their own tables.

Caught up with other folks on this. The separation of tables here is based on the expected timing of data entry or need to update.

1. Users may wish to add notes about the session after processing steps.
2. Session/Subject data entry may occur separately from file management, and file organization may change mid-project.

This way, we permit later entry, and avoid cascading deletes or updates to this session.Session table with many downstream connections.

[CBroz1]

Everything looks good here. The only piece I would change would be to move the integration test to the test folder of workflow-session. This could be done pretty easily via PR to the CBroz1:nwb branch which has an open PR we plan to close out this week.

[kabilar]

Thanks @bendichter! Great work. A few minor documentation suggestions above.

[bendichter]

@kabilar all look good. I do not have merge privileges so feel free to merge when you are ready.

[kabilar]

Thanks @bendichter!